docs: align subtitle and output guidance with render.py#107
Open
hydraxman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bold-overlaysubtitle margin to matchSUB_FORCE_STYLErender.py's current scaling and frame-rate behaviorgrade.py, which owns the--filteroptionrender.py's module documentationProblem
The editing guide still documents
MarginV=35, while the renderer usesMarginV=90for vertical-video safe zones. It also suggests passing--filtertorender.py, but that option is exposed bygrade.pyinstead.Testing
python3 -m py_compile helpers/*.py— passedpython3 helpers/render.py --help— confirmed no--filteroptionpython3 helpers/grade.py --help— confirmed--filteris availablegit diff --check— passedAddresses the documentation drift tracked in #64.
Summary by cubic
Align docs with current
render.pybehavior and fix the stale subtitle margin in its docstring. Updatedbold-overlaytoMarginV=90, clarifiedrender.pyrenders at 24 fps and scales the long edge to 1920px (1280px in draft), and pointed--filterusage tograde.py.Written for commit 4cd7c04. Summary will update on new commits.