Add support for aria-label username fields#399
Open
raxod502 wants to merge 1 commit intobrowserpass:masterfrom
Open
Add support for aria-label username fields#399raxod502 wants to merge 1 commit intobrowserpass:masterfrom
raxod502 wants to merge 1 commit intobrowserpass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an example of a login page that this PR adds support for: https://portal.hmc.edu
(No account needed to view the login page, just click Login in the top right.)
Here is the input field for the username, which doesn't match any of the existing patterns:
However,
aria-label="Username"seems pretty unambiguous to me, so I think we might as well match on it.