Fix false negative of clevis detection in initramfs#2
Open
speed47 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to
-o pipefail, on my system the script didn't properly report clevis as being present in the initramfs becauselsinitramfsgets killed early due togrep -q clevisactually matching successfully. There are several ways to fix that, a single-line fix would have been to usespongebetweenlsinitramfsandgrep, but it might not be installed everywhere. So, I opted for a slighly longer version, which is to disable-o pipefailjust for this line. This fixed the behaviour on my system.Thanks for this script!