Refactor: add helper methods to reduce code duplication#6
Merged
Conversation
- Add get_model_log() to centralize widget lookup and avoid scattered string-based ID queries throughout the codebase - Add for_each_model_log() to eliminate repeated model iteration patterns (was duplicated 5+ times) - Update submit_prompt(), cmd_new(), and stream_to_model() to use the new helpers This reduces coupling to the ID generation logic and makes the code more maintainable. All 33 tests pass.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scattered string-based ID queries throughout the codebase
patterns (was duplicated 5+ times)
the new helpers
This reduces coupling to the ID generation logic and makes the
code more maintainable. All 33 tests pass.