Partitioner for Python 3#275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage ? 92.74%
=========================================
Files ? 32
Lines ? 5282
Branches ? 0
=========================================
Hits ? 4899
Misses ? 383
Partials ? 0Continue to review full report at Codecov.
|
polsm91
left a comment
There was a problem hiding this comment.
There are many divisions, make sure that you never divide by 0 :)
In the future, if we need to add more partition strategies consider using Enum. I think it's okay for now to have the strategy as a string.
|
|
||
|
|
||
| def partitioner_split(father): | ||
| if hasattr(config, "partition_strategy"): |
There was a problem hiding this comment.
Suggestion :)
strategy = getattr(config, "partition_strategy". "SIMPLE")
return Partitioner(father, strategy).split()b244134 to
006968b
Compare
polsm91
left a comment
There was a problem hiding this comment.
Not working. The tokens partitions eats the memory and does a loooong loop because of "token_range_size"
892085e to
9861982
Compare
This is the implementation of the dynamic task granularity scheduler. All previous functionality still works.