version update to 1.12#7
Conversation
updated gradle and scripts. tried updating old files but would not work. going to re add important lines to build.gradle later, but this is necessary to even get the workspace setup
|
updated gradle so i could initialize the dev environment |
sorts the imports, removes unused ones, and potentially corrects broken ones where methods were moved
todo: fix config generation at the bottom, need to convert to modname:itemname. verify: ambiguous corrected import; minecraftforge.fml.common.registry.GameData no longer exists. auto corrected to net.minecraftforge.registries.GameData this is an internal registry and should not be used. net.minecraftforge.fml.common.registry.GameRegistry is the closest to original version and may have necessary functions to correct.
verify correct change to compareTo
again, only thing left is the registry problem
todo: figure out biome checker and loot table system
|
well, that is the first pass of fixes. mostly easy, some a bit complicated. |
|
@bspkrs if you are interested in looking at this and giving me pointers that would defiantly help. this is my first real dive into modding, so i really would like to figure this out |
|
Looks good so far, I can do a proper review of it later on. I'll talk to Bspkrs sometime soon about getting this repo moved to the org. |
|
Cool, currently I'm looking into if I can pull the core dep from github rather then the bspk.rs repo. That might make it a bit eaiser and have fewer steps in the future... |
|
Here's something that might help |
|
You can use cursemaven.com to pull it into the project :) |
|
i cant seem to get the dependency to resolve... any thoughts? |
turns out there was an extra step not in the instructions where i had to add a gradle plugin...
|
Turns out the maven link did not want to work, so I had to use a gradle plugin instead to grab from curse. It should work now... |
2 participants
Trying to update to 1.12. Just making the pr for now, will try adding the changes I have so far when I get home.
Edit: forgot to mention, issue #6