Add some tests - #5
Merged
Merged
Conversation
This was
linked to
issues
Oct 30, 2025
Closed
yusufmalikul
marked this pull request as ready for review
October 30, 2025 12:23
Contributor
|
@yusufmalikul The unit tests that re-do pieces of the code just to reply back correctly to the SDK ... will always pass? What we've essentially done here is a mock server that always replies exactly what we want. There's a value in this. But let's perhaps just write it as mock server that serves mock requests. And the unit test suite with arrays of conditions could be separate. Then I'd like to be able to do 2 things:
This would be immensely valuable. We could assume that those tests would read ~/.config/bsub/config.json perhaps for a proper API key cases? For proper testing, I think we should assume some mocky types of jobs. For example: |
Collaborator
Author
|
@wkoszek added test against prod server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive test suite to the bsubio-go SDK, significantly improving code maintainability, reliability, and confidence in future changes. The test suite provides 38.4% code coverage with a focus on critical client functionality.
What's Changed:
httptest