Conversation
…fixes #147) Migrate from deprecated dockers syntax to docker_manifests and add ARM64 support for multi-architecture Docker images. Changes: - Split Docker builds into separate amd64 and arm64 images - Use buildx for multi-platform builds - Create docker_manifests for all tags (latest, version, major, major.minor) - Each manifest includes both amd64 and arm64 images - Docker automatically pulls correct architecture Images built: - ghcr.io/bsubio/cli:v0.14.1-amd64 - ghcr.io/bsubio/cli:v0.14.1-arm64 Manifests created (multi-arch): - ghcr.io/bsubio/cli:v0.14.1 - ghcr.io/bsubio/cli:v0 - ghcr.io/bsubio/cli:v0.14 - ghcr.io/bsubio/cli:latest Benefits: - Fixes GoReleaser deprecation warning - Adds ARM64 support (Apple Silicon, AWS Graviton, Raspberry Pi) - Automatic platform detection - Future-proof configuration
ReviewArchitecture: Migration from deprecated Issue: Dockerfile copies from Fix needed (.goreleaser.yaml:258, :276): Should be: goarch: amd64
goos: linuxWhy: GoReleaser builds binaries like PR title: Correct format per Conventional Commits. |
|
@claude apply: and use appropriate binary from the goreleaser build so that bin/bsubio_linux_amd64/bsubio goes to amd64 image, and other binaries go to other respective images/architectures. |
|
Claude finished @wkoszek's task —— View job Changes Applied
SummaryAdded Updated Note: --- | |
- Add goos: linux to both amd64 and arm64 docker configs - Update Dockerfile to use GoReleaser's binary path convention - Ensures correct architecture-specific binaries are copied to images Co-authored-by: Adam Koszek <wkoszek@users.noreply.github.com>
ReviewDockerfile path change (.goreleaser.yaml:262, Dockerfile:9) Missing platform flag (amd64 section) Config correctness Ship it. |
Summary
Migrate from deprecated
dockerssyntax todocker_manifestsand add ARM64 support for multi-architecture Docker images.Changes
buildxfor multi-platform buildsdocker_manifestsfor all tags (latest, version, major, major.minor)Images Built
Individual architecture images:
ghcr.io/bsubio/cli:v0.14.1-amd64ghcr.io/bsubio/cli:v0.14.1-arm64Multi-arch manifests:
ghcr.io/bsubio/cli:v0.14.1ghcr.io/bsubio/cli:v0ghcr.io/bsubio/cli:v0.14ghcr.io/bsubio/cli:latestUsage
Platform Support
Now works on:
Benefits
Fixes #144
Fixes #147