Skip to content

fix(overlay-topics): require verified Mandala state authority - #536

Merged
ty-everett merged 2 commits into
mainfrom
codex/mandala-review-remediation-20260915
Sep 15, 2026
Merged

ty-everett merged 2 commits into
mainfrom
codex/mandala-review-remediation-20260915

Conversation

@ty-everett

@ty-everett ty-everett commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Program and scope

Impact

  • Public package source or manifest changed: @bsv/overlay-topics 1.8.0.
  • Security-sensitive boundary changed.
  • Infrastructure source changed: reference overlay-server state adapter and its tests.
  • Documentation and migration guidance changed.

Non-genesis admin actions fail closed without an admin-history verifier. The reference storage manager provides an exact asset/outpoint query, and the server's lazy adapter uses the existing history API for compatibility with its locked dependency. Registration belongs to its own genesis. Token ownership must match the stored source outpoint, asset and amount; optional input linkage corroborates that record. Duplicate/invalid linkage indices are rejected consistently by admission and lookup.

Existing wire fields and serialization remain unchanged. Custom adapters need the documented verifier and authoritative owner rows. Coordinate admission/lookup upgrades and audit historical records before replay. The optional TypeScript verifier member preserves source compatibility; it does not permit bypassing runtime verification.

Verification

  • Full workspace build and typecheck; root health, lint and format checks.
  • Full Overlay Topics coverage suite: 579 tests across 47 suites (one pre-existing TODO); existing valid transfer, blinding, delegated admin, conservation and control-gate fixtures retained with authoritative state.
  • Defensive authority-contract, missing/mismatched-owner, decoder/index and Mongo history tests.
  • Packed ESM consumer, public exports and strict declaration resolution.
  • Overlay linkage mutation target expanded to the complete decoder: 82.05%.
  • Overlay-server frozen install, build, lint and state-adapter/lifecycle tests against the currently locked dependency.
  • Generated documentation, compiled package examples and dependency audit.
  • Local patch coverage: 98.88% (88/89 changed line/branch points). Hosted CI 35023863393 succeeded: 24 successful checks, 11 expected scope skips. Exact-head Sonar has zero bugs/vulnerabilities/code smells and no new hotspots; CodeQL has no open alerts; no review threads remain.

Security and dependencies

  • No runtime dependency or lockfile change.
  • No new override, suppression, advisory dismissal or skipped test.
  • Source changes and migration reviewed for compatibility and persistence impact.
  • Exact-head hosted gates, zero new Sonar findings/hotspots, zero new CodeQL alerts and resolved review threads verified.

Release and operations

  • No workstation publication; use the protected Release workflow after merge.
  • Package version, release ledger, changelog and operator migration guide updated.
  • No database collection migration or public API removal.
  • Final exact-head diff reviewed; protected release completed successfully.

Published release evidence

Admin merge: 152ebe2aa8766bf98001df1e666e9f0f18ba6631. Main CI and CodeQL passed.

Protected Release 35024582312 succeeded, including vulnerability scanning, SLSA/CycloneDX attestations, npm publication, signature verification and final reconciliation. It published Overlay Topics 1.8.0, SDK 2.7.0, Message Box Client 2.5.1, Wallet Relay 0.5.0, Paymail 2.4.8, fund-wallet 1.5.1, 402-pay 0.3.1, and Wallet Toolbox Client/Mobile 2.13.1. All nine registry/latest versions, SHA-256 tarball digests and SHA-512 integrity values were independently checked against the hosted candidate.

No fleet deployment was performed. Custom Mandala adapters and historical records require the documented migration review before deployment. The deferred overlay integration work remains outside this wave.

@sonarqubecloud

Copy link
Copy Markdown

@ty-everett
ty-everett marked this pull request as ready for review September 15, 2026 21:15
@ty-everett
ty-everett merged commit 152ebe2 into main Sep 15, 2026
35 checks passed
@ty-everett
ty-everett deleted the codex/mandala-review-remediation-20260915 branch September 15, 2026 21:15
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...overlays/topics/src/mandala/MandalaTopicManager.ts 95.45% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant