Repository navigation
fix(ci): install Playwright Linux deps without sudo bunx - #421
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue: fixes the v0.1.0 Release run (https://github.com/bubbleptr/pace/actions/runs/36862811532).
Summary
build-linuxjob failed at "Install Playwright Chromium and Xvfb" withsudo: bunx: command not found: sudo resets PATH, sosudo bunx playwright install-deps chromiumcannot find bunx. v0.1.0 is the first tag release since Linux was added (feat: ship Linux window controls and release assets with macOS #411), so this step had never run.bunx playwright install --with-deps chromium. Playwright runs its apt step throughsudo -- sh -c …itself when not root (playwright-corecoreBundle.js), which is passwordless on GitHub runners.Test plan
bun run test:release18/18Releasefrommainwith tagv0.1.0(dispatch uses main's workflow and checks out the tag's code)