Repository navigation
fix(release): keep x64 in Linux artifact names and drop the AppImage blockmap sidecar - #423
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue: release blockers found by the v0.1.0 Release run (https://github.com/bubbleptr/pace/actions/runs/36867220929). Linux packaging has never run on a tag before; this is the first release with Linux.
Summary
electron-builderexpands the globalartifactName's${arch}tox86_64(AppImage) /amd64(deb) (builder-util/out/arch.jsgetArtifactArchName), so the build producedPace-0.1.0-x86_64.AppImage/Pace-0.1.0-amd64.debwhile scripts, workflow, docs and tests expect-x64. Pin per-targetartifactNameforappImageanddeb.latest-linux.ymlblockMapSize) and emits no.blockmapsidecar; electron-updater'sAppImageUpdaterreads the embedded one (FileWithEmbeddedBlockMapDifferentialDownloader). Remove the sidecar from the checksum step, upload paths,publish-release.sh, the publish test fixture (now asserts it is not uploaded) anddocs/release/linux.md. The macOS zip blockmap is unchanged.Test plan
dist/hasPace-0.1.0-x64.AppImage,Pace-0.1.0-x64.deb,latest-linux.yml(path/url →-x64.AppImage)Pace-0.1.0-arm64.zip+.blockmap,latest-mac.yml)dist/, every upload path exists,--checkOKbun run test:release18/18