Skip to content

fix(release): scope the AppImage smoke to the cold-start launch #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bubbleptr merged 1 commit into from
Oct 1, 2026
Merged

fix(release): scope the AppImage smoke to the cold-start launch #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ jobs:
- name: Test the unpacked package
timeout-minutes: 15
run: bun run test:e2e:packaged:linux --workers=1 --max-failures=1 --reporter=line
# Only the cold-start case: the unpacked package above already ran the whole
# suite. The empty-PATH case cannot launch an AppImage at all, because its
# AppRun is `#!/usr/bin/env bash` and a real desktop launcher always has PATH.
- name: Test the AppImage opens
timeout-minutes: 10
env:
Expand All @@ -192,7 +195,7 @@ jobs:
PACE_E2E_ELECTRON_ARGS=--ozone-platform=x11 \
APPIMAGE_EXTRACT_AND_RUN=1 \
xvfb-run -s "-screen 0 1920x1080x24" \
bunx playwright test --config e2e/playwright.config.ts e2e/smoke/m5-2-preflight.spec.ts --workers=1 --max-failures=1 --reporter=line
bunx playwright test --config e2e/playwright.config.ts e2e/smoke/m5-2-preflight.spec.ts --grep "cold start reaches preflight" --workers=1 --max-failures=1 --reporter=line
- name: Generate SHA-256 checksums
working-directory: dist
env:
Expand Down
Loading