Repository navigation
fix(spike): enforce durable host and approval boundaries - #434
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 Durable 多端 spike 的宿主边界:跨会话审批通过持久任务记录校验归属,在读取已有决定、写入和放行前被拒绝,取消等待或宿主重启后也保持有效;每次订阅持有独立身份,旧 watch 不再覆盖新快照,文档创建也不会落在监听间隙;畸形 JSON 或消息参数只关闭出错客户端,宿主继续服务。
浏览器连接增加精确 Origin 白名单,原生客户端仍须通过 token 鉴权。常规启动日志不再输出凭证;提供显式
bun run web:link,原生客户端和验收脚本从本地 token 文件读取。测试为各自 Vite 端口注册明确来源。覆盖 #426 的订阅、畸形消息、日志凭证与 Origin 检视,以及 #431 的审批归属和文档创建竞态。其他历史检视未包含在本层。
验证:每个缺陷先红后绿。本次增加真实审批取消、宿主重启后遇到其他会话历史错误决定的两个回归用例;宿主层独立 spike typecheck、15 文件 / 62 项测试通过,上层同步后 spike typecheck、15 文件 / 66 项测试通过。此前整栈已通过根 typecheck、lint、build、1977 项根测试和完整 12 幕三端演示。复跑及行为边界见 docs/research/durable-multiview-review-fixes.md。