Repository navigation
chore(deps): upgrade Pi to 1.0.4 - #439
Merged
Merged
Conversation
Pi 1.0.3 renames the azure-openai-responses provider to azure, so the provider icon follows. Pi 1.0.4 starts the codemode worker from a data: URL read off disk; our chunking gives that worker relative imports a data: URL cannot resolve, so the packaged build loads the emitted file directly (it lives in app.asar and cannot change under a running process). The verbatim copies of Pi's slash commands, prompt template loading and the pi-tui autocomplete separator are unchanged in 1.0.4; only their version notes move.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #438.
Summary
@earendil-works/pi-ai/pi-coding-agent1.0.0 → 1.0.4 (exact pins; spikes unchanged).azure-openai-responsestoazure; the provider icon key follows.data:URL read off disk (upstream #10439). Our chunking gives the worker relative imports to shared protocol chunks, which cannot resolve from adata:URL, so codemode broke in the packaged build (the shipped-bundle test caught it). The build transform now makes it load the emitted file directly: files inside app.asar cannot be swapped while the process runs, so the reason for the upstream change does not apply here. The replacement must match exactly once, so if upstream changes this code the build fails loudly.autocompleteSeparatorRegexare byte-identical between 1.0.0 and 1.0.4; only the version notes move.Test plan
bun run typecheck/lintbun run test(168 files / 1977 tests)bun run build(fix(desktop): bundle a single pi-ai copy so OAuth refresh works when packaged #438's guard passes: single pi-ai1.0.4copy)node --test scripts/test-bundled-runtime.mjs4/4 (including OAuth refresh and codemode)