Add support for testing DIP dialect's 2D correlation op with OpenCV#23
Open
meshtag wants to merge 10 commits intobuddy-compiler:mainfrom
Open
Add support for testing DIP dialect's 2D correlation op with OpenCV#23meshtag wants to merge 10 commits intobuddy-compiler:mainfrom
meshtag wants to merge 10 commits intobuddy-compiler:mainfrom
Conversation
zhanghb97
requested changes
Jan 30, 2022
Member
zhanghb97
left a comment
There was a problem hiding this comment.
- I think the test for the Corr2D result belongs to the integration test.
- Can we try to use the GoogleTest framework to verify correctness? Because we are using the GoogleTest framework for other parts according to the previous discussions in our community.
- Currently, the result shows all the cases are different, it's because opencv rounds up, right?
Member
Author
|
I was thinking of moving test.h file in |
Member
What about moving to |
Member
|
I run the |
EllisLambda
pushed a commit
to EllisLambda/buddy-benchmark
that referenced
this pull request
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add support for testing
dip.corr_2d's output with OpenCV.All available kernels were used for correlating an image using DIP and OpenCV followed by comparison of their respective outputs.