Remove the create_directory(std::error_code&) overload#200
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the create_directory(std::error_code&) overload and simplifies internal functions for temporary directory creation.
- Removed the redundant create_directory overload with error code reporting.
- Refactored temporary directory creation to use a single implementation that throws on failure.
Comments suppressed due to low confidence (1)
src/create.cpp:30
- The updated logic in validate_prefix now throws an exception when the prefix is empty, which differs from the original behavior where an empty prefix was considered valid. Please confirm if this behavior change is intentional.
if (prefix.empty() || (++prefix.begin() == prefix.end() && prefix.is_relative() && !prefix.has_root_path())) {
bugdea1er
force-pushed
the
create-directory
branch
from
91c703e to
98ea4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And tidy up internal functions