Fix TOC/TOU in directory::copy

[bugdea1er]

Underlying implementation of directory::copy now opens a directory_iterator on the from path to avoid TOC/TOU vulnerability

[Copilot]

Pull Request Overview

This PR aims to fix a TOC/TOU vulnerability in the implementation of directory::copy by opening a directory_iterator on the source path and copying its contents individually. Key changes include:

• Introducing a new helper function, copy_directory, to iterate over and copy directory contents safely.
• Updating the directory::copy function to use copy_directory.
• Adjusting .clang-tidy configuration to ignore naming length warnings for the new iterator variable "it".

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/directory.cpp	Added copy_directory function and updated directory::copy implementation.
.clang-tidy	Updated ignored identifiers list to include the new variable name "it".

Comments suppressed due to low confidence (2)

src/directory.cpp:25

• [nitpick] Consider using a more descriptive variable name instead of 'it' (e.g. 'dirIter') to improve readability.

fs::directory_iterator it = fs::directory_iterator(from, ec);

src/directory.cpp:30

• [nitpick] Using fs::directory_iterator() as the end iterator can be less clear; consider storing the end iterator in a variable to clarify the loop condition.

for (; !ec && it != fs::directory_iterator(); it.increment(ec)) {

[Copilot]

Pull Request Overview

This PR addresses a potential TOC/TOU vulnerability in directory copying by replacing direct calls to fs::copy with a new copy_directory function that uses fs::directory_iterator. Key changes include:

• Introducing copy_directory to open a directory iterator on the source path.
• Updating move and directory::copy functions to use copy_directory.
• Adjusting .clang-tidy options to ignore identifier-length warnings for the variable "it".

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/directory.cpp	Introduces copy_directory and replaces fs::copy calls with this function.
.clang-tidy	Updates settings to ignore identifier-length for parameters "it".

Comments suppressed due to low confidence (1)

src/directory.cpp:21

• Consider ensuring that the target directory 'to' exists before copying files. This would avoid potential runtime errors when constructing file paths inside the copy loop.

fs::directory_iterator it = fs::directory_iterator(from, ec);

[Copilot]

Pull Request Overview

This PR improves the security of directory copying by mitigating TOC/TOU vulnerabilities and refactoring the directory deletion function.

• Renames the recursive deletion function to remove_directory for clarity.
• Iterates through directory entries in directory::copy to avoid time-of-check to time-of-use issues.
• Updates .clang-tidy configuration to ignore the "it" parameter for identifier-length checks.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/directory.cpp	Refactored deletion function and replaced fs::copy with iteration to mitigate TOC/TOU vulnerability.
.clang-tidy	Adjusted ignored names for readability-identifier-length checks.