Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the ABI definition for Windows by always exporting library classes with __declspec(dllexport), removing the conditional TMP_BUILDING_DLL logic.
- Removes the TMP_BUILDING_DLL condition for Windows builds
- Unconditionally defines abi as __declspec(dllexport) on Windows
- Retains the default visibility attribute for non-Windows platforms
Files not reviewed (2)
- meson.build: Language not supported
- src/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
src/abi.hpp:4
- Removing the TMP_BUILDING_DLL check results in using __declspec(dllexport) unconditionally on Windows. Please verify that this change does not lead to linking issues when importing the library.
#if defined TMP_BUILDING_DLL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently you can always specify
dllexportfor library classes on Windows, so this pull request eliminates the need to add theTMP_BUILDING_DLLcompilation definition