Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request ensures that files have their buffered input flushed before moving to a new location, reducing the risk of data loss. Key changes include:
- Removal of an explicit flush in the test, as the flushing is now handled within file::move.
- Addition of a flush call at the beginning of file::move.
- Minor comment update to explain the rationale behind using a copy rather than a hard link.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/file.cpp | Removed redundant flush call in the test after shifting flush logic. |
| src/file.cpp | Added flush call at the beginning of file::move to ensure data is written before moving. |
Files not reviewed (1)
- include/tmp/file: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flush call at the beginning of
file::move