Implement file_handle for auto-closing an open file#209
Merged
Conversation
# Conflicts: # src/file.cpp
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a RAII wrapper class, file_handle, to manage the lifetime of native file descriptors so that files are automatically closed without manual intervention in file::copy.
- Introduces file_handle with constructor, conversion operator, and destructor for auto-closing file handles
- Replaces manual file closing calls in file::copy with the RAII mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the need to close the file manually in
file::copy