Refactor create_file#217
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the temporary file creation logic by extracting the file reopening functionality into a separate function, aiming to reduce duplicate code.
- Introduces a new function, reopen_file, for reopening temporary files.
- Updates create_file to use the new reopen_file function and improved error handling.
Comments suppressed due to low confidence (2)
src/file.cpp:102
- Undefined variable 'mode' used in _wfreopen; consider replacing it with the passed in 'mdstring' to correctly specify the file open mode.
file = _wfreopen(path.c_str(), make_mdstring(mode), file);
src/file.cpp:85
- The file pointer is passed by value to reopen_file, so reassigning it inside the function will not update the caller's variable. Consider passing it by reference (std::FILE*&) or returning the updated file pointer.
void reopen_file(const fs::path::value_type* mdstring, std::FILE* file, std::error_code& ec) noexcept {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move out the common code