Add recv stream id so stream can be tracked during callbacks#4
Open
gfodor wants to merge 1 commit into
Open
Conversation
Author
|
Actually this PR can probably be closed - I did not understand there was one GenServer per stream. That said, the integer id for the stream does seem to be useful information in general so maybe worth merging. |
Owner
|
My intended way for using the stream was that if you need an id, that id can be def handle_stream(%Stream{} = _stream, state) do
state = Map.put(state, :recv_stream_id, self())
{:continue, state}
endwithout the need of patching this library. Consider that Sounds good? |
457f53a to
04123c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there doesn't seem to be a way to identify where incoming bytes came from in terms of the original stream. (You can only see the connection, and the stream struct lacks identifying information.) This adds the recv_stream id to the struct.