Skip to content

Enhance OffsetValues description in IfcOffsetCurveByDistances - #1146

Open
RickBrice wants to merge 1 commit into
buildingSMART:ifc4.3-mainfrom
RickBrice:RickBrice-patch-1
Open

Enhance OffsetValues description in IfcOffsetCurveByDistances#1146
RickBrice wants to merge 1 commit into
buildingSMART:ifc4.3-mainfrom
RickBrice:RickBrice-patch-1

Conversation

@RickBrice

Copy link
Copy Markdown
Contributor

Expanded the description of OffsetValues to clarify constraints and behavior regarding the basis curve.

Expanded the description of OffsetValues to clarify constraints and behavior regarding the basis curve.
@github-actions

Copy link
Copy Markdown

PR Validation -- schema generators

Checks:

  • ✓ EXPRESS schema valid
  • ✓ New entities present in structure.json
  • ✓ MD docs for new entities
  • ✓ PEnum convention
  • ✓ New UML Psets/Qtos emitted
  • ✓ Modified psets emitted
  • ✓ Schema SHACL validation

Detected:

  • New entities: (none)
  • New PEnums: (none)
  • New UML Psets/Qtos: (none)
  • UML files changed: (none)
  • MD docs changed (1): IfcOffsetCurveByDistances.md
📋 EXPRESS schema diff (baseline vs PR head)

Express schema differences

0 items

Missing data

🎉 No issues 🎉

Type definitions

🎉 No issues 🎉

Entity definitions

🎉 No issues 🎉

Constraints

🎉 No issues 🎉

SHACL validation report

DefinitionForEnumLiteral

  • The resource 'IfcBridgePartTypeEnum.SURFACESTRUCTURE' has no definition
  • The resource 'IfcRailwayPartTypeEnum.DILATIONTRACK' has no definition

DefinitionForPropertyOrQuantity

  • The Property 'Pset_AirSideSystemInformation.AirFlowSensible' has no definition
  • The Property 'Pset_AirSideSystemInformation.TotalAirFlow' has no definition
  • The Property 'Pset_AirTerminalBoxPHistory.AirFlowCurve' has no definition
  • The Property 'Pset_AirTerminalOccurrence.AirFlowType' has no definition
  • The Property 'Pset_AirToAirHeatRecoveryTypeCommon.PrimaryAirFlowRateRange' has no definition
  • The Property 'Pset_AirToAirHeatRecoveryTypeCommon.SecondaryAirFlowRateRange' has no definition
  • The Property 'Pset_SpaceThermalPHistory.ExhaustAirFlowRate' has no definition
  • The Property 'Qto_WallBaseQuantities.GrossFootPrintArea' has no definition
  • The Property 'Qto_WallBaseQuantities.NetFootPrintArea' has no definition

DefinitionForResource

  • The resource 'IfcSurfaceFeature' has no definition
  • The resource 'IfcURIReference' has no definition

LeafEntityHasPredefinedType

  • Leaf IfcObject 'IfcAlignmentCant' has no PredefinedType attribute
  • Leaf IfcObject 'IfcAlignmentHorizontal' has no PredefinedType attribute
  • Leaf IfcObject 'IfcAlignmentSegment' has no PredefinedType attribute
  • Leaf IfcObject 'IfcAlignmentVertical' has no PredefinedType attribute
  • Leaf IfcObject 'IfcAsset' has no PredefinedType attribute
  • Leaf IfcObject 'IfcBorehole' has no PredefinedType attribute
  • Leaf IfcObject 'IfcBuilding' has no PredefinedType attribute
  • Leaf IfcObject 'IfcBuildingStorey' has no PredefinedType attribute
  • Leaf IfcObject 'IfcCivilElement' has no PredefinedType attribute
  • Leaf IfcObject 'IfcDistributionCircuit' has no PredefinedType attribute
  • Leaf IfcObject 'IfcGeomodel' has no PredefinedType attribute
  • Leaf IfcObject 'IfcGeoslice' has no PredefinedType attribute
  • Leaf IfcObject 'IfcSite' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralCurveConnection' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralCurveMemberVarying' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralLinearAction' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralLoadCase' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralPlanarAction' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralPointAction' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralPointConnection' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralPointReaction' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralResultGroup' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralSurfaceConnection' has no PredefinedType attribute
  • Leaf IfcObject 'IfcStructuralSurfaceMemberVarying' has no PredefinedType attribute
  • Leaf IfcObject 'IfcWallStandardCase' has no PredefinedType attribute
  • Leaf IfcObject 'IfcZone' has no PredefinedType attribute

PropertyForDefinition

  • For document 'AcidityConcentration.md/a/properties/docs' a property cannot be found
  • For document 'ActualWork.md/a/properties/docs' a property cannot be found
  • For document 'AdjustmentRange.md/a/properties/docs' a property cannot be found
  • For document 'AdjustmentRangeStepValue.md/a/properties/docs' a property cannot be found
  • For document 'AdjustmentValues.md/a/properties/docs' a property cannot be found
  • For document 'AdmixturesDescription.md/a/properties/docs' a property cannot be found
  • For document 'AffectsSurroundings.md/a/properties/docs' a property cannot be found
  • For document 'Aggregation.md/a/properties/docs' a property cannot be found
  • For document 'AirflowCurve.md/a/properties/docs' a property cannot be found
  • For document 'AirflowSensible.md/a/properties/docs' a property cannot be found
  • For document 'AirflowType.md/a/properties/docs' a property cannot be found
  • For document 'AlkalinityConcentration.md/a/properties/docs' a property cannot be found
  • For document 'AppearanceGrade.md/a/properties/docs' a property cannot be found
  • For document 'ApplicableStructuralDesignMethod.md/a/properties/docs' a property cannot be found
  • For document 'Area.md/a/properties/docs' a property cannot be found
  • For document 'Arrangement.md/a/properties/docs' a property cannot be found
  • For document 'AssessmentOfRisk.md/a/properties/docs' a property cannot be found
  • For document 'BaseChamfer.md/b/properties/docs' a property cannot be found
  • For document 'BearingStrength.md/b/properties/docs' a property cannot be found
  • For document 'BoilingPoint.md/b/properties/docs' a property cannot be found
  • For document 'BottomCover.md/b/properties/docs' a property cannot be found
  • For document 'CO2Content.md/c/properties/docs' a property cannot be found
  • For document 'COContent.md/c/properties/docs' a property cannot be found
  • For document 'CarbonContent.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreBaseHeight.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreBaseWidth.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreMiddleHeight.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreSpacing.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreTopHeight.md/c/properties/docs' a property cannot be found
  • For document 'CenterCoreTopWidth.md/c/properties/docs' a property cannot be found
  • For document 'CentreOfGravityInX.md/c/properties/docs' a property cannot be found
  • For document 'CentreOfGravityInY.md/c/properties/docs' a property cannot be found
  • For document 'CombustionTemperature.md/c/properties/docs' a property cannot be found
  • For document 'CompStrength.md/c/properties/docs' a property cannot be found
  • For document 'CompStrengthPerp.md/c/properties/docs' a property cannot be found
  • For document 'CompactedVolume.md/c/properties/docs' a property cannot be found
  • For document 'CompressiveStrength.md/c/properties/docs' a property cannot be found
  • For document 'Condition.md/c/properties/docs' a property cannot be found
  • For document 'CoreBaseHeight.md/c/properties/docs' a property cannot be found
  • For document 'CoreBaseWidth.md/c/properties/docs' a property cannot be found
  • For document 'CoreMiddleHeight.md/c/properties/docs' a property cannot be found
  • For document 'CoreSpacing.md/c/properties/docs' a property cannot be found
  • For document 'CoreTopHeight.md/c/properties/docs' a property cannot be found
  • For document 'CoreTopWidth.md/c/properties/docs' a property cannot be found
  • For document 'Count.md/c/properties/docs' a property cannot be found
  • For document 'CrossSectionArea.md/c/properties/docs' a property cannot be found
  • For document 'CurrentCarryingCapasity.md/c/properties/docs' a property cannot be found
  • For document 'DefinitionType.md/d/properties/docs' a property cannot be found
  • For document 'DimensionalChangeCoefficient.md/d/properties/docs' a property cannot be found
  • For document 'DissolvedSolidsContent.md/d/properties/docs' a property cannot be found
  • For document 'DraftBaseOffset.md/d/properties/docs' a property cannot be found
  • For document 'DraftSideOffset.md/d/properties/docs' a property cannot be found
  • For document 'DynamicViscosity.md/d/properties/docs' a property cannot be found
  • For document 'EavesHeight.md/e/properties/docs' a property cannot be found
  • For document 'EdgeDraft.md/e/properties/docs' a property cannot be found
  • For document 'ExhaustAirFlowRate.md/e/properties/docs' a property cannot be found
  • For document 'Exponent.md/e/properties/docs' a property cannot be found
  • For document 'FinishCeilingHeight.md/f/properties/docs' a property cannot be found
  • For document 'FinishFloorHeight.md/f/properties/docs' a property cannot be found
  • For document 'FlangeBaseFillet.md/f/properties/docs' a property cannot be found
  • For document 'FlangeChamfer.md/f/properties/docs' a property cannot be found
  • For document 'FlangeDepth.md/f

SHACL report truncated -- full report in the workflow artifact bundle.

See workflow run for failure details.

@RickBrice

Copy link
Copy Markdown
Contributor Author

This PR aims to improve the documentation based on how IfcPointByDistanceExpression offsets are implemented by a few organizations. The interpretation of OffsetVertical is being debated. Recommend holding this PR until there is broad agreement on OffsetVertical representing local or global Z direction.

Additional discussion is available at #1151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant