Fix boolean query binding for flag-style parameters#10
Conversation
When binding query parameters to a struct, if a boolean field's corresponding query parameter is present but empty (e.g. `?Flag`), it was previously causing a parsing error because `strconv.ParseBool` fails on empty strings. This change modifies `setField` in `context.go` to treat empty strings as `true` for boolean fields, enabling flag-style query parameters. Explicit values like `?Flag=false` are still respected.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `Mount` and `Any` methods to `App` and `Group` to easily register standard `http.Handler`s (like `grpc-gateway`) and support multi-method routes. - Added `WrapHTTPHandler` utility. - Fixed `BindQuery` to treat empty boolean params (flags) as `true` (e.g. `?Sector`). - Added integration tests for mounting and boolean flags. Co-authored-by: bernardoforcillo <28314446+bernardoforcillo@users.noreply.github.com>
1 participant
This PR fixes an issue where boolean query parameters without values (flags) were causing binding errors.
Changes:
context.go: UpdatedsetFieldto handle empty strings for boolean values by setting them totrue.Verification:
TestBindQueryFlagwhich confirmed the issue and verified the fix.PR created automatically by Jules for task 15309276825870585861 started by @bernardoforcillo