Refactor router config to root and enable default Recovery middleware#6
Conversation
- Moved TrieRouterConfig, ParamParser, WildcardParser and their default implementations from `routers/trie.go` to `amaro` package (root). - Renamed TrieRouterConfig to RouterConfig for generic usage. - Moved `middlewares.Recovery` to `amaro.Recovery` (root) to avoid circular dependencies. - Updated `amaro.New` to include `Recovery()` middleware by default for production readiness. - Updated tests and documentation to reflect these changes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
bernardoforcillo
deleted the
router-config-refactor-prod-readiness-15971429849834483556
branch
1 participant
This PR refactors the router configuration by moving
TrieRouterConfigand related parser types to the rootamaropackage as genericRouterConfigtypes. It also enhances production readiness by moving theRecoverymiddleware to the root package and enabling it by default inamaro.New(). This ensures all applications have panic recovery out of the box while resolving circular dependencies between the core and middleware packages.PR created automatically by Jules for task 15971429849834483556 started by @bernardoforcillo