Skip to content

Refactor wildcard matching logic in TrieRouter#9

Merged
bernardoforcillo merged 1 commit into
mainfrom
refactor-wildcard-matching-17146026927635272500
Jan 6, 2026
Merged

Refactor wildcard matching logic in TrieRouter#9
bernardoforcillo merged 1 commit into
mainfrom
refactor-wildcard-matching-17146026927635272500

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This PR refactors the wildcard matching logic in routers/trie.go. Previously, the code manually reconstructed the captured wildcard path by concatenating the current path segment and the remaining search path. This was marked as a "hack" in the comments.

The new implementation captures the state of the search path (currentPath) at the beginning of each loop iteration. When a wildcard node is matched, this captured path is used directly as the parameter value. This approach is cleaner, more robust, and avoids unnecessary string concatenation.

Tests were added (and subsequently removed after verification) to ensure that edge cases like double slashes (e.g., /static/a//b) are handled correctly and consistently with the previous behavior. Existing tests in routers/trie_test.go also pass.


PR created automatically by Jules for task 17146026927635272500 started by @bernardoforcillo

Replaced manual string reconstruction hack in CatchAll logic with a cleaner approach using `currentPath` capture. This simplifies the code and avoids potential edge cases with path separators.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@bernardoforcillo bernardoforcillo marked this pull request as ready for review January 6, 2026 07:46
@bernardoforcillo bernardoforcillo merged commit 5e5cb9f into main Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant