Refactor wildcard matching logic in TrieRouter#9
Conversation
Replaced manual string reconstruction hack in CatchAll logic with a cleaner approach using `currentPath` capture. This simplifies the code and avoids potential edge cases with path separators.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the wildcard matching logic in
routers/trie.go. Previously, the code manually reconstructed the captured wildcard path by concatenating the current path segment and the remaining search path. This was marked as a "hack" in the comments.The new implementation captures the state of the search path (
currentPath) at the beginning of each loop iteration. When a wildcard node is matched, this captured path is used directly as the parameter value. This approach is cleaner, more robust, and avoids unnecessary string concatenation.Tests were added (and subsequently removed after verification) to ensure that edge cases like double slashes (e.g.,
/static/a//b) are handled correctly and consistently with the previous behavior. Existing tests inrouters/trie_test.goalso pass.PR created automatically by Jules for task 17146026927635272500 started by @bernardoforcillo