You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR brings in fixes suggested by discord user msa6867#1823.
Given the user's comment about not being comfortable with Git, @blockjoe wanted to just pull in the changes since they were quick/simple so that the user could say if this is what they were suggesting.
Issue:
Nodes past 20 relays mark (majority of them) are being calculated at 100% median latency + 30% P90 latency.
Note: this is artificial data, not from an actual session.
As you see, using the actual formula you take nodes out of the top bucket with both median/p90 within requirements (<150ms). After the adjustment, this will no longer happen.
Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").
💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.
Second Issue:
weightedSuccessLatency is used for both sorting and for calculating weighting; on the other hand, the main role of medianSuccessLatency is merely as a stepping stone to calculate weightedSuccessLatency. Thus it is logical inconsistency to use medianSuccessLatency rather than weightedSuccessLatency in a conditional statement to calculate the weighting. This leads to a node whose median is equal or under 150ms but whose weighted is over 150ms to avoid weighting penalization. For example:
Actual assigned weight assuming first issue is fixed (latencyDifference conditional on medianSuccessLatency)
Name Median P90 Weighted Latency latencyDifference WeightFactor
Node1 - 100 135 110.5 0 10
Node2 - 150 650 300 0 10
Actual assigned weight assuming first issue is fixed (latencyDifference conditional on weightedSuccessLatency)
Name Median P90 Weighted Latency latencyDifference WeightFactor
Node1 - 100 135 110.5 0 10
Node2 - 150 650 300 150 5
Note: this is artificial data, not from an actual session.
As you see, after the adjustment, node2's weighting is properly reduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in fixes suggested by discord user
msa6867#1823.Given the user's comment about not being comfortable with Git, @blockjoe wanted to just pull in the changes since they were quick/simple so that the user could say if this is what they were suggesting.
Issue:
Nodes past 20 relays mark (majority of them) are being calculated at 100% median latency + 30% P90 latency.
Note: this is artificial data, not from an actual session.
As you see, using the actual formula you take nodes out of the top bucket with both median/p90 within requirements (<150ms). After the adjustment, this will no longer happen.