This repository was archived by the owner on Nov 24, 2025. It is now read-only.
T-10526 - PHD Client Integration#908
Merged
Merged
Conversation
|
This pull request has been linked to 2 tasks:
|
commoddity
marked this pull request as draft
August 11, 2022 02:38
commoddity
changed the title
crisog
approved these changes
Aug 30, 2022
crisog
left a comment
crisog
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Nice job on this 👍🏽
crisog
changed the title
crisog
marked this pull request as ready for review
September 19, 2022 18:08
commoddity
changed the title
rem1niscence
previously approved these changes
Sep 28, 2022
rem1niscence
left a comment
rem1niscence
left a comment
Contributor
There was a problem hiding this comment.
left a few comments but none of them are blocking, although recommend to check on them
crisog
suggested changes
Nov 7, 2022
added 18 commits
January 11, 2023 11:21
…fetching from PHD
commoddity
force-pushed
the
pascal/phd-client
branch
from
January 11, 2023 20:33
8eb3e87 to
d397484
Compare
rem1niscence
previously approved these changes
Jan 11, 2023
rem1niscence
approved these changes
Jan 18, 2023
crisog
self-requested a review
January 18, 2023 14:51
crisog
approved these changes
Jan 18, 2023
adshmh
approved these changes
Jan 18, 2023
This was referenced Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR to create functionality to pull Portal data from PHD (Pocket HTTP Database) and fall back to MongoDB if fails.
Main functionality is written but will need extensive testing.