Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Setup Node 16
- name: Setup Node 20
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org
scope: '@openfin'
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-HOWTOs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion how-to/automation-testing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Application will be running on port 5050 `http://localhost:5050`
Run the tests the following way:

```shell
cd automation/create-window-js
cd automation-testing/create-window-js
npm install
npm run test-local-mocha
```
Expand Down
1 change: 1 addition & 0 deletions how-to/automation-testing/create-window-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "OpenFin Container Starter Automation Tests",
"scripts": {
"build": "echo Nothing to build",
"build-client": "echo Nothing to build",
"test-local-mocha": "of-automation http://localhost:5050/manifest.fin.json ./tests/**/*.spec.js --reporter ./mocha.reporter.json",
"setup": "npm install && npm run build",
"validate": "npm --prefix ../../../ run validate"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "OpenFin Container Starter Automation Tests",
"scripts": {
"build": "echo Nothing to build",
"build-client": "echo Nothing to build",
"test-local-mocha": "of-automation http://localhost:5050/manifest.fin.json ./tests/**/*.spec.js --reporter ./mocha.reporter.json",
"setup": "npm install && npm run build",
"validate": "npm --prefix ../../../ run validate"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('Launch External Process', () => {

it('The title should be set', async () => {
const title = await WebDriver.getTitle();
expect(title).to.equal('OpenFin Template');
expect(title).to.equal('HERE Template');
});

it('The url should be set', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "OpenFin Container Starter Automation Tests",
"scripts": {
"build": "echo Nothing to build",
"build-client": "echo Nothing to build",
"test-local-mocha": "of-automation http://localhost:5050/manifest.fin.json ./tests/**/*.spec.js --reporter ./mocha.reporter.json",
"setup": "npm install && npm run build",
"validate": "npm --prefix ../../../ run validate"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('Use Window Options', () => {

it('The title should be set', async () => {
const title = await WebDriver.getTitle();
expect(title).to.equal('Window Options Example');
expect(title).to.equal('Window Options Builder');
});

it('The url should be set', async () => {
Expand Down
1 change: 1 addition & 0 deletions how-to/use-dynamic-manifest/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "index.js",
"scripts": {
"build": "npm run build-server",
"build-client": "echo Nothing to build",
"build-server": "tsc --project ./server",
"start": "npm run server",
"server": "node ./server/build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion how-to/use-launch-external-process/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Follow the instructions below to get up and running.

## App asset breakdown

This is an example shape as it related to the top level application manifest property as seen [here](https://resources.here.io/docs/core/develop/manifests/#section-appassets-properties).
This is an example shape as it related to the top level application manifest property as seen in the [HERE Core manifest documentation for appAssets properties](https://resources.here.io/docs/core/develop/manifests/#section-appassets-properties).

`public/app.json`

Expand Down
1 change: 1 addition & 0 deletions how-to/use-licensed-codecs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "A demonstration of a where you need to put configuration in order to enable licensed codecs.",
"scripts": {
"build": "echo This project does not require a build step.",
"build-client": "echo Nothing to build",
"kill": "node ./scripts/kill.mjs",
"client": "node ./scripts/launch.mjs",
"start": "npx --yes http-server ./public -p 5050 -c-1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "43.101.2",
"main": "server.js",
"scripts": {
"build-client": "echo Nothing to build",
"start": "npx tsx server.ts"
},
"keywords": [],
Expand Down
1 change: 0 additions & 1 deletion how-to/use-logging/use-loguploader-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"dependencies": {
"@openfin/core": "^43.101.2",
"eslint": "^9.35.0",
"markdown-cli": "^1.6.0",
"prettier": "^3.6.2"
}
}
Loading
Loading