Simplify linting#30
Draft
raycashmore wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting Migration Notes
Overview
This document records the migration to a centralized ESLint v9 flat config shared across all workspaces, plus follow-up cleanup that removed markdownlint from the repo's automation.
Motivation
The previous setup had significant duplication and drift:
.eslintrc.jsfiles across workspacesChanges Made
1. Centralized ESLint config (flat config)
Shared package:
packages/eslint-config/@openfin-web-starter/eslint-configpackages/eslint-config/eslint.config.jsThe shared config is preset-driven and type-aware:
@eslint/jsrecommendedeslint-plugin-importflat recommendedeslint-plugin-promiseflat recommendedtypescript-eslintrecommendedTypeCheckedwith:parserOptions.project: './tsconfig.eslint.json'parserOptions.tsconfigRootDir: process.cwd()eslint-plugin-jsdocflat recommended for TypeScriptRepo-specific rules/overrides kept in the shared config:
import/no-unresolved+import/namedoff)import/order) aligned to legacy behavior (currentlywarn)crypto.randomUUID/window.crypto.randomUUIDjsdoc/require-jsdockept enabled aswarnto avoid blocking during migration cleanup2. Workspace config simplification
Each workspace now uses a tiny flat config that spreads the shared config:
Workspace config files are named
eslint.config.mjs.3. Removed markdownlint from automation
markdownlint is no longer part of this repo's workflow:
npm run markdownlint:.github/workflows/ci.ymlAGENTS.md.vscode/extensions.jsonHistorical markdownlint artifacts were removed from workspaces during the migration (e.g.
.markdownlint.json).4. Prettier check stability (generated/auxiliary files)
Some workspaces generate files during build (for example
public/style/core-web-styles.css). To keepprettier-checkstable, workspace.prettierignorefiles were updated to ignore:eslint.config.mjspublic/style/core-web-styles.cssRoot Scripts / CI
Recommended check-only pipeline:
npm cinpm run prettier-checknpm run eslintnpm run buildReferences