Adding .gitignore and making README nicer in the Github UI#2
Open
kozross wants to merge 4 commits intobunder:masterfrom
Open
Adding .gitignore and making README nicer in the Github UI#2kozross wants to merge 4 commits intobunder:masterfrom
kozross wants to merge 4 commits intobunder:masterfrom
Conversation
|
Hi @kozross , went to build this today, and also noticed the README lacked build/dependency docs. I am not as familiar with CMake as regular make, so I had to do some googling. I know this is old but just wanted to mention that I think the work is valuable. If anyone else is coming along this PR, just run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former change makes it a bit easier to dev with, since you now won't have to worry about checking in build artifacts. The latter is so that that README is nicer to read.
If you want, I'm happy to rewrite the README a bit to explain how to build this - you don't document your dependencies, for example.