Skip to content

Remove the deadline #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auryn-macmillan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the deadline #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions contracts/burnSignal.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ contract VoteProposalPool {
uint32 _deadline
)
external
validateDeadline(_deadline)
validateDescription(_data)
// commenting out this because it serves no purpose in the current version.
// validateDeadline(_deadline)
validateDescription(_data)
validateName(_name)
returns (VoteProposal newProposal)
{
Expand All @@ -92,13 +93,13 @@ contract VoteProposalPool {
newProposal.options(1));
}


/* commenting out this function because it serves no purpose in the current version.
modifier validateDeadline(uint32 _deadline) {
require(_deadline >= (now + 604800), "Deadline must be at least one week from now");
require(_deadline <= (now + 31622400), "Deadline must be no more than one year from now");
_;
}

*/
modifier validateName(string memory _name) {
bytes memory nameBytes = bytes(_name);
require(nameBytes.length <= 100, "Proposal name must be less than 100 characters (ASCII)");
Expand Down