Repository navigation
External Links #290
Description
Activity
Usually you'll want external links to open in a new tab.
Don't make this assumption, please :)
Sure! I definitely wasn't implying that this should be the default behavior. I only meant that it should be possible to pass something like
newTab=true.We can do something like an
{{external-link}}modifier which allows you to intercept external link handling with your own logic:External Link: Any link/url not recognizable by the ember router.
Instance-specific:
And
handleExternalLink()will receive theclickevent.Or register this globally:
// app/application/route.ts export default class ApplicationRoute extends Route { beforeModel() { this.externalLinkService.setHandler(this.handleExternalLinkGlobal); } @action handleExternalLinkGlobal() { // so sth here } }
And use it like this:
If there is no handler given as first argument to the modifier or no global handler... then the
{{external-link}}modifier does nothing.eeeek. would work nicely with the
(external-link)helper:
This makes no sense when used directly in the template, like:
However, it becomes very useful when passing
Links around, e.g. to build a navigation menu, because you can then easily use the same primitive in a common code path:I'm not sure about the exact API yet.
Another thing: Usually you'll want external links to open in a new tab. This should not need to be defined at the "call site" where the
Linkis used on an<a>element, but rather where theLinkis defined.Something like this maybe? #289