Removal of link cache breaks the test example in the README

[jeffhertzler]

Because the cache is removed the link created with linkFor and the link in the template no longer match which causes the test to fail by trying to redirect the browser.

Repro: https://github.com/jeffhertzler/ember-link-repro

I know that 2.0.0 was marked as breaking and this was somewhat expected, but the example is wrong now and it's not clear to me exactly how you would write this kind of test anymore.

[buschtoens]

Broken as of #658.

Thanks for providing a repro! And sorry, that this has hit you.

I'll try to think of a solution, but I'll happily accept ideas / PRs as well.

[enspandi]

In my case, I'm overriding the helper like this

this.owner.unregister('helper:link');
this.owner.register(
  'helper:link',
  class extends Helper {
    compute(positional: LinkHelperPositionalParams, named: LinkHelperNamedParams) {
      return linkFor(named.route, named.models);
    }
  }
);

And have my own linkFor function that manages a cache... not the best solution probably, but it's not much code either. Good enough for integration tests.

[jeffhertzler]

Is enabling the cache in the library only in test mode a viable solution? It looks like the cache was removed to make support for ember 4 work (maybe that's already how it worked?). is there an alternative path to adding the cache back that doesn't rely on using fast-json-stable-stringify if it's causing issues? Also, at first glance it seems like onTransitionTo and onReplaceWith don't need to factor into the cache key. I don't know if these are viable suggestions. I'll think about it and familiarize myself with the codebase a bit more.