Skip to content

getLinkParamsFromRouteInfo does not collect models for the entire RouteInfo tree #797

Description

@bertdeblock

At the moment, only paramNames on the leaf RouteInfo instance is used here:
https://github.com/buschtoens/ember-link/blob/main/ember-link/src/services/link-manager.ts#L100

But I think we need to traverse up the entire tree (using the parent property) to collect all models?

Otherwise, Ember's router throws an error when creating links using the fromURL option, and providing a URL with e.g. multiple dynamic segments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions