Open
Conversation
This was referenced Sep 23, 2018
begrs
approved these changes
May 17, 2019
begrs
left a comment
There was a problem hiding this comment.
Its definetely a rough work around to attach an element to the dom to check the width but ++ for cross browser fix that should work 100% of the time.
Withouth this fix, simple scrollbar does not work properly for mobile browsers with no permanent scrollbars or Safari 11.1. (even though the docu states it should)
begrs
suggested changes
May 17, 2019
begrs
left a comment
There was a problem hiding this comment.
My bad for missing this in my last review:
this does not work if the script is added before the dom is loaded.
but its easy to fix:
d.addEventListener('DOMContentLoaded', function () { ss.scrollWidth = getScrollWidth(); initAll(); }); ss.initEl = initEl; ss.initAll = initAll;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a simple function to detect the browser scrollbar width and adapt the style offset to this exact value.