Skip to content

Get schema from commit metadata in for bootstrap and incremental queries#31

Open
umehrot2 wants to merge 8 commits into
bvaradar:hudi_bootstrap_code_reviewfrom
umehrot2:umehrot2_hudi_bootstrap_code_review
Open

Get schema from commit metadata in for bootstrap and incremental queries#31
umehrot2 wants to merge 8 commits into
bvaradar:hudi_bootstrap_code_reviewfrom
umehrot2:umehrot2_hudi_bootstrap_code_review

Conversation

@umehrot2
Copy link
Copy Markdown

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #31 into hudi_bootstrap_code_review will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##             hudi_bootstrap_code_review      #31      +/-   ##
================================================================
+ Coverage                         16.84%   16.87%   +0.03%     
  Complexity                          891      891              
================================================================
  Files                               388      388              
  Lines                             17023    17003      -20     
  Branches                           1691     1685       -6     
================================================================
+ Hits                               2868     2870       +2     
+ Misses                            13788    13767      -21     
+ Partials                            367      366       -1     
Impacted Files Coverage Δ Complexity Δ
.../scala/org/apache/hudi/HudiBootstrapRelation.scala 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/hudi/common/table/timeline/TimelineLayout.java 92.85% <0.00%> (+14.28%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf49ab...7409d7b. Read the comment docs.

@bvaradar bvaradar force-pushed the hudi_bootstrap_code_review branch 2 times, most recently from d874def to f441b0c Compare May 28, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants