Repository navigation
surveys hub: search, filter and sort the cards in the browser - #231
Merged
Merged
Conversation
The /surveys page renders its controls hidden, a GET form on its own path with option lists drawn from the rows it lists, and every card carries its facts as data attributes (slug, title, organisation, region, stations, years, types, licence, DOI). One same-origin script, /src/surveys-hub.js, reveals the form and drives it: every search word must match the title, organisation, region or slug; each select narrows to one value; sorts by title, station count, newest, oldest or organisation, a survey with no stated year last; the view rides the URL query so it can be shared and reloaded; Clear is a plain link. Without script the page is the whole list in title order, as before. The index page test allows the hub's one script on the same terms as the survey page's dialog scripts and pins the controls contract the script reads; the Caddy page-script pin covers the new file; a jsdom test drives the script against a fixture that mirrors the engine's markup. The hub rows now carry year_start and year_end for the sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /surveys page renders its controls hidden, a GET form on its own path with option lists drawn from the rows it lists, and every card carries its facts as data attributes (slug, title, organisation, region, stations, years, types, licence, DOI). One same-origin script, /src/surveys-hub.js, reveals the form and drives it: every search word must match the title, organisation, region or slug; each select narrows to one value; sorts by title, station count, newest, oldest or organisation, a survey with no stated year last; the view rides the URL query so it can be shared and reloaded; Clear is a plain link. Without script the page is the whole list in title order, as before.
The index page test allows the hub's one script on the same terms as the survey page's dialog scripts and pins the controls contract the script reads; the Caddy page-script pin covers the new file; a jsdom test drives the script against a fixture that mirrors the engine's markup. The hub rows now carry year_start and year_end for the sort.