Skip to content

Web Enrollment Tweaks - #7

Merged
bwatters-r7 merged 3 commits into
bwatters-r7:feature/certificate-web-enrollmentfrom
smcintyre-r7:pr/collab/20752
Mar 4, 2026
Merged

Web Enrollment Tweaks#7
bwatters-r7 merged 3 commits into
bwatters-r7:feature/certificate-web-enrollmentfrom
smcintyre-r7:pr/collab/20752

Conversation

@smcintyre-r7

@smcintyre-r7 smcintyre-r7 commented Feb 12, 2026

Copy link
Copy Markdown

This fixes a couple of bugs in the Web Enrollment module that I ran into while testing.

  • Fixes the handling of PFX so the datastore option is used, enabling exploitation of ESC2 and ESC3 (tested and confirmed working now)
  • Fixes the naming of the AdcsOpts module to be consistent with other files that refer to it as AD CS with a space, making it ad_cs_ and AdCs respectively
  • Fixes ESC15 exploitation by moving the ADD_CERT_APP_POLICY option to AdCsOpts
  • Improves option validation by moving the checks into AdCsOpts#validate_options, now the other modules get the validation too
  • Improves the option handling in CertRequest#create_csr by using #fetch, the caller can explicitly over ride the datastore by setting an option to nil, previously the caller couldn't say for example that there should be no ALT_SID without the method falling back to the datastore
  • Improves esc8 UX by setting the Http::Auth option to ntlm by default because it's the only valid setting

@bwatters-r7
bwatters-r7 merged commit a644047 into bwatters-r7:feature/certificate-web-enrollment Mar 4, 2026
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants