Skip to content

Fix internal adapter script loading #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwente merged 1 commit into from
Oct 10, 2026
Merged

Fix internal adapter script loading #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to MMM-MessageCenter are documented in this file.

## 0.7.2 - 2026-10-10

### Fixed

- Load internal notification adapters from the module directory so weather,
Remote Control, PublicTransportHub, MyScoreboard, and standard MagicMirror
notification ingestion work in real MagicMirror installations.

## 0.7.1 - 2026-10-10

### Added
Expand Down
2 changes: 1 addition & 1 deletion MMM-MessageCenter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ Module.register("MMM-MessageCenter", {
"integrations/my-scoreboard.js",
"integrations/weather.js",
"integrations/generic-alert.js"
];
].map((script) => this.file(script));
},

getTranslations() {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mmm-messagecenter",
"version": "0.7.1",
"version": "0.7.2",
"description": "Hardware-independent notification and attention hub for MagicMirror²",
"private": true,
"type": "commonjs",
Expand Down
19 changes: 18 additions & 1 deletion test/MMM-MessageCenter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,15 @@ test("provides the complete English translation entry point", () => {
});

test("loads the ordered internal notification adapter registry", () => {
assert.deepEqual(definition.getScripts(), [
const requested = [];
const scripts = definition.getScripts.call({
file(script) {
requested.push(script);
return `/modules/MMM-MessageCenter/${script}`;
}
});

assert.deepEqual(requested, [
"integrations/adapter-registry.js",
"integrations/standard-message.js",
"integrations/remote-control.js",
Expand All @@ -152,6 +160,15 @@ test("loads the ordered internal notification adapter registry", () => {
"integrations/weather.js",
"integrations/generic-alert.js"
]);
assert.deepEqual(scripts, [
"/modules/MMM-MessageCenter/integrations/adapter-registry.js",
"/modules/MMM-MessageCenter/integrations/standard-message.js",
"/modules/MMM-MessageCenter/integrations/remote-control.js",
"/modules/MMM-MessageCenter/integrations/public-transport-hub.js",
"/modules/MMM-MessageCenter/integrations/my-scoreboard.js",
"/modules/MMM-MessageCenter/integrations/weather.js",
"/modules/MMM-MessageCenter/integrations/generic-alert.js"
]);
});

test("defaults to the full page display mode", () => {
Expand Down
Loading