Fixed all BLOCKER, SERIOUS, and MINOR issues from code review v0.9.0

.github/workflows/ci.yml

@@ -14,6 +14,8 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v4
+      with:
+        submodules: recursive
 
     - name: Set up Docker Buildx
       uses: docker/setup-buildx-action@v3

.gitignore

@@ -1,4 +1,5 @@
 build/
+build-*/
 *.o
 *.elf
 *.bin

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "userland"]
+	path = userland
+	url = https://github.com/byteshiftlabs/thunderos-userland.git

CONTRIBUTING.md

@@ -12,7 +12,6 @@ Thank you for your interest in contributing to ThunderOS! This guide will help y
 
 2. **Check current status**
    - Look at the README banner for any active code freezes
-   - See [FREEZE.md](FREEZE.md) if a freeze is active
    - Review open issues and pull requests
 
 3. **Set up your environment**

Makefile

@@ -27,11 +27,12 @@ INCLUDE_DIR := include
 # Build configuration
 ENABLE_TESTS ?= 0
 TEST_MODE ?= 0
+SINGLE_SHELL ?= 0
 
 # Compiler flags
 CFLAGS := -march=rv64gc -mabi=lp64d -mcmodel=medany
 CFLAGS += -nostdlib -nostartfiles -ffreestanding -fno-common
-CFLAGS += -O0 -g -Wall -Wextra
+CFLAGS += -O0 -g -Wall -Wextra -Werror
 CFLAGS += -I$(INCLUDE_DIR)
 
 # Enable kernel tests (set ENABLE_TESTS=0 to disable)
@@ -44,6 +45,11 @@ ifeq ($(TEST_MODE),1)
     CFLAGS += -DTEST_MODE
 endif
 
+# Single-shell mode: launch only one user shell in normal runtime.
+ifeq ($(SINGLE_SHELL),1)
+	CFLAGS += -DSINGLE_SHELL_MODE
+endif
+
 # Linker flags
 LDFLAGS := -nostdlib -T kernel/arch/riscv64/kernel.ld
 
@@ -63,7 +69,17 @@ KERNEL_C_SOURCES := $(wildcard $(KERNEL_DIR)/*.c) \
 ifeq ($(ENABLE_TESTS),1)
     KERNEL_C_SOURCES += tests/unit/test_memory_mgmt.c \
                         tests/unit/test_elf.c \
-                        tests/unit/test_memory_isolation.c
+                        tests/unit/test_memory_isolation.c \
+                        tests/unit/test_vterm.c \
+                        tests/unit/test_pmm.c \
+                        tests/unit/test_kmalloc.c \
+                        tests/unit/test_errno.c \
+						tests/unit/test_ext2_vfs.c \
+						tests/unit/test_wait_queue.c \
+						tests/unit/test_sync_primitives.c \
+						tests/unit/test_syscalls.c \
+						tests/unit/test_pipes.c \
+						tests/unit/test_scheduler_soak.c
 endif
 
 KERNEL_ASM_SOURCES := $(wildcard $(KERNEL_DIR)/arch/riscv64/*.S)
@@ -128,6 +144,7 @@ help:
 	@echo "$(BOLD)Run Targets:$(RESET)"
 	@echo "  $(GREEN)make run$(RESET)          Build and run in QEMU (text mode)"
 	@echo "  $(GREEN)make qemu$(RESET)         Same as 'make run'"
+	@echo "  $(GREEN)make qemu-docker$(RESET)  Run in Docker with supported QEMU 10.1.2"
 	@echo "  $(GREEN)make qemu-gpu$(RESET)     Run with VirtIO GPU (VNC on :5900)"
 	@echo "  $(GREEN)make qemu-gpu-web$(RESET) Run with GPU + noVNC (http://localhost:6080)"
 	@echo ""
@@ -256,20 +273,32 @@ force_fs: userland
 	@echo ""
 
 userland:
-	@echo ""
-	@echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"
-	@echo "$(BOLD)$(BLUE)  Building Userland Programs$(RESET)"
-	@echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"
-	@chmod +x build_userland.sh
-	@./build_userland.sh
-	@echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"
-	@echo ""
+	@if [ ! -f userland/lib/user.ld ]; then \
+		echo ""; \
+		echo "$(RED)✗ Userland submodule not initialized$(RESET)"; \
+		echo "  Run: git submodule update --init --recursive"; \
+		echo ""; \
+		exit 1; \
+	 else \
+		echo ""; \
+		echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"; \
+		echo "$(BOLD)$(BLUE)  Building Userland Programs$(RESET)"; \
+		echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"; \
+		chmod +x build_userland.sh; \
+		./build_userland.sh; \
+		echo "$(BOLD)$(BLUE)━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━$(RESET)"; \
+		echo ""; \
+	fi
 
 test:
-	@cd tests/scripts && bash test_runner.sh
+	@cd tests/scripts && bash run_all_tests.sh
 
 test-quick:
-	@cd tests/scripts && bash test_runner.sh --quick
+	@cd tests/scripts && bash run_all_tests.sh --quick
+
+qemu-docker:
+	@chmod +x run_os_docker.sh
+	@./run_os_docker.sh
 
 qemu: userland fs
 	@rm -f $(BUILD_DIR)/kernel/main.o