Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation addresses the data-exposure path and provides focused regression coverage.
0 open findings
What changed in this PR
Prevents collection exports from copying files through symlinks while preserving lightweight-export behavior.
Changes:
- Rejects file, directory, and dangling symlinks before copying originals.
- Adds regression coverage for primary, supporting-source, and lightweight exports.
| File | Description |
|---|---|
skills/sourcepack/scripts/sourcelens/pack.py |
Rejects symlinked acquisition originals. |
tests/test_pack.py |
Covers symlink rejection and cleanup behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection exports currently follow unregistered symlinks inside an acquisition folder, allowing an unrelated local file to be copied into the exported pack. Reject encountered file, directory, and dangling symlinks before copying originals, including supporting sources; failed exports leave no published destination.
Regression tests reproduce the previous behavior and cover ordinary portable exports plus the lightweight export path. Validation:
PYTHONPATH=skills/sourcepack/scripts python3 -m unittest discover -s tests -v— 101 tests, OK, with two optional document-interpreter tests skipped. Independent code review andgit diff --checkpassed.