Skip to content

fix: inform users of password requirements in register/change forms - #4576

Merged
Nayor merged 1 commit into
masterfrom
fix/password-requirements-ui
Sep 14, 2026
Merged

Nayor merged 1 commit into
masterfrom
fix/password-requirements-ui

Conversation

@Nayor

@Nayor Nayor commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • v6_api now requires 10+ characters with an uppercase letter, a lowercase letter, a digit and a special character when a password is created or changed (not at login) — see fix: scope password policy to creation/change, not login v6_api#2240.
  • Adds a hint under each new-password field so users see the requirement before submitting instead of hitting a rejection: signup, forgot-password reset, and the account settings password change.
  • Deliberately not added to the login field or the "current password" field on account settings, matching the backend scoping.

Test plan

  • npm run lint:no-fix clean (0 errors)
  • npm run build succeeds

🤖 Generated with Claude Code

Summary by CodeRabbit

  • User Experience
    • Added password requirement guidance to account password changes, sign-up, and password reset forms.
    • Clarified that passwords must be at least 10 characters and include uppercase, lowercase, numeric, and special characters.
    • Explained that leaving the account password field blank keeps the current password.
  • Localization
    • Added the password requirement message to the translatable content.

Backend now requires 10+ chars with upper/lower/digit/special on
password creation/change (not login). Added a hint under each
new-password field (signup, forgot-password reset, account settings) so
users see the requirement before submitting instead of hitting a
rejection.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the bug Something isn't working label Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b9a1688d-fbdd-4a43-8a43-336385113094

📥 Commits

Reviewing files that changed from the base of the PR and between 526182c and 7cf956e.

📒 Files selected for processing (3)
  • src/views/user/AccountView.vue
  • src/views/user/LoginView.vue
  • src/views/user/utils/FormField.vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The account and authentication forms now show password requirements. The account form also explains that an empty new-password field keeps the current password. The related API message is registered for translation.

Changes

Password guidance

Layer / File(s) Summary
Password hints and translation support
src/views/user/AccountView.vue, src/views/user/LoginView.vue, src/views/user/utils/FormField.vue
The account, signup, and change-password forms now display translated password requirements. The account hint also describes the empty-field behavior. The API message is registered for translation.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 7cf95

The change adds password guidance without an identified impact on authentication workflows.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: informing users about password requirements in registration and password-change forms.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/password-requirements-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the password line
Ten small carrots mark the sign
Uppercase, lowercase, digits too
A special mark joins the crew
Leave it blank, and old stays true

Comment @coderabbitai help to get the list of available commands.

@Nayor
Nayor merged commit f041349 into master Sep 14, 2026
6 checks passed
@Nayor
Nayor deleted the fix/password-requirements-ui branch September 14, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant