Skip to content

fix(tracking): log status-check failures instead of swallowing them - #4579

Open
Nayor wants to merge 1 commit into
masterfrom
fix/tracking-status-silent-failure
Open

Nayor wants to merge 1 commit into
masterfrom
fix/tracking-status-silent-failure

Conversation

@Nayor

@Nayor Nayor commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Résumé

Dans l'éditeur de sortie, MapInputRow.vue proposait l'option "utiliser une activité synchronisée" uniquement si GET /users/:id/status réussissait ET rapportait au moins un vendeur configured. Toute erreur (401, réseau, ...) était avalée silencieusement — l'utilisateur voyait exactement la même chose que "aucun tracker connecté", sans indication qu'un problème existait.

C'est précisément ce qui a masqué un incident de désynchronisation du secret JWT entre v6_api et c2c_tracking (401 systématique, déjà corrigé côté infra) : rien côté frontend n'indiquait qu'un appel échouait.

Changement

L'erreur est maintenant loguée via console.error, avec un commentaire expliquant le contexte. Le comportement de repli (GPX local uniquement) reste inchangé — c'est le fallback sûr — seule l'observabilité change.

Test plan

  • npm run lint propre (1 warning no-console attendu, cohérent avec le pattern déjà utilisé ailleurs dans le repo, ex. NearbyStopsSection.vue)
  • prettier --check propre

Summary by CodeRabbit

  • Bug Fixes
    • Tracking status retrieval failures are now logged, making errors easier to identify instead of failing silently.

MapInputRow silently dropped any error from GET /users/:id/status,
which made the option to pick a synced activity disappear with zero
indication of why - identical to "no tracker connected". This is
exactly what hid a JWT-secret-mismatch incident between v6_api and
c2c_tracking from the frontend side.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the bug Something isn't working label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7c333ebf-b7b1-4004-b285-7bf7434d8bba

📥 Commits

Reviewing files that changed from the base of the PR and between ef3c6a0 and 6ea70df.

📒 Files selected for processing (1)
  • src/views/wiki/edition/utils/MapInputRow.vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Changes

Tracking status error visibility

Layer / File(s) Summary
Status error logging
src/views/wiki/edition/utils/MapInputRow.vue
The trackingService.getStatus failure callback now logs errors with console.error. Failed requests are no longer silent.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6ea70

Tracking-status failures are now visible in logs while local GPX activity remains available, so the change is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: logging tracking status-check failures instead of silently ignoring them.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tracking-status-silent-failure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit sees the tracker fail
And leaves an error in the trail
No silent hops, no hidden fright
The console shows the missing light
The map row knows what went wrong

Comment @coderabbitai help to get the list of available commands.

@Nayor
Nayor deployed to pr-preview September 17, 2026 09:54 — with GitHub Actions Active
@Nayor Nayor self-assigned this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant