fix: validate target column exists in dataset and reject non-CSV files#349
Open
shivv23 wants to merge 1 commit into
Open
fix: validate target column exists in dataset and reject non-CSV files#349shivv23 wants to merge 1 commit into
shivv23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve robustness of the target field assignment endpoint by validating that the target column actually exists in the dataset, and rejecting non-CSV file types.
Changes
add_target_service: Now returns 400 if the file is not CSV, and validates the target column exists infile.columnsbefore creating the recordValidation