Contribution to Issue 1616 (not a solution yet)#1617
Open
evgaster wants to merge 5 commits intoc3d:stablefrom
Open
Contribution to Issue 1616 (not a solution yet)#1617evgaster wants to merge 5 commits intoc3d:stablefrom
evgaster wants to merge 5 commits intoc3d:stablefrom
Conversation
Author
|
This PR is about the keymap file only. |
evgaster
changed the title
The plane numbers where off compared to the "Key positions" documentation. Corrected that. Added a bit of description. This doesn't solve the issue. The changes are of value anyway. Signed-off-by: Ed@vanGasteren.net
The code always treated an @ as a start of comment character. That made it impossible to use @ in a double quoted string assigned to a key. I also caused imbalance of the double quotes. That caused incorrect handling of the rest of the file. Now only outside double quotes the @ is handled as a start of comment character. Signed-off-by: Ed@vanGasteren.net
Signed-off-by: Ed@vanGasteren.net
An other round of description of the file. A few mapping fixes. Signed-off-by: Ed@vanGasteren.net
Fixed this discrepancy between overlay and map. Signed-off-by: Ed@vanGasteren.net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No solution.
Better description of the db48x keymap file.
Proper handling of @ character in double quoted strings.
Fixed the weird single quote in all 4 keymap files.
A few fixes of mappings (better inline with .../db48x/help/db48x.md#keyboard-interaction).