Fixes #1593: DB48X keyboard not visible on Samsung Galaxy S23 Ultra#1630
Open
mdjurfeldt wants to merge 1 commit intoc3d:stablefrom
Open
Fixes #1593: DB48X keyboard not visible on Samsung Galaxy S23 Ultra#1630mdjurfeldt wants to merge 1 commit intoc3d:stablefrom
mdjurfeldt wants to merge 1 commit intoc3d:stablefrom
Conversation
sim/sim-window.cpp:MainWindow::MainWindow set a border-image URL referring to the keymap image using the actual file name which works in the desktop case. However, Android bundles are strict about resources and the correct way to refer to the image is using the alias keymap.png. This change enables the keyboard to be displayed both on desktop and Android devices like phones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simulator: Refer to keyboard image using alias keymap.png
sim/sim-window.cpp:MainWindow::MainWindow set a border-image URL referring to the keymap image using the actual file name which works in the desktop case. However, Android bundles are strict about resources and the correct way to refer to the image is using the alias keymap.png. This change enables the keyboard to be displayed both on desktop and Android devices like phones.