Skip to content

Update workflow and Makefile#100

Open
Darvisim wants to merge 4 commits intoc3lang:mainfrom
Darvisim:main
Open

Update workflow and Makefile#100
Darvisim wants to merge 4 commits intoc3lang:mainfrom
Darvisim:main

Conversation

@Darvisim
Copy link

@Darvisim Darvisim commented Mar 9, 2026

main.yml

  • Existing workflow replaced with a robust one.
  • Removes steps requiring manual packaging.

Makefile

  • Updated to now support parallel builds rather sequential builds.
  • User can now choose a select number of libraries they want only for compilation.

Darvisim added 3 commits March 9, 2026 21:37
* Update main.yml

Updated with a robust workflow

* Update Makefile

Updated Makefile to now support parallel builds
@lerno
Copy link
Contributor

lerno commented Mar 14, 2026

I am not sure why the ktx bindings were changed and what the update is doing.

@Darvisim
Copy link
Author

Darvisim commented Mar 14, 2026

I am not sure why the ktx bindings were changed and what the update is doing.

When i tried compiling for ktx i got these errors:

Compiling ktx
 421: fn KtxErrorCode texture1_create_from_stream(KtxStream* stream,
 422:   KtxTextureCreateFlags createFlags,
 423:   KtxTexture1** newTex) @cname("ktxtexture1_CreateFromStream");
 424: fn bool KtxTexture1.needs_transcoding(&self) @cname("ktxTexture1_NeedsTranscod
ing");
                          ^^^^^^^^^^^^^^^^^
(C:/Users/User/vendor/libraries/ktx.c3l/ktx.c3i:424:21) Error: This method is alread
y defined for 'KtxTexture1'.

221: macro KtxErrorCode KtxTexture1.load_image_data(&self,
222:    char* pBuffer,
223:    usz bufSize) => self.vtbl.loadImageData(self, pBuffer, bufSize);
224: macro bool KtxTexture1.needs_transcoding(&self) => self.vtbl.needsTranscoding(s
elf);
                            ^^^^^^^^^^^^^^^^^
(C:/Users/User/vendor/libraries/ktx.c3l/ktx.c3i:224:24) Note: The previous definitio
n was here.

 452: fn uint KtxTexture2.get_oetf(&self) @cname("ktxTexture2_GetOETF");
 453: fn KhrDfModel KtxTexture2.get_color_model_enum(&self) @cname("ktxTexture2_GetC
olorModel_e");
 454: fn bool KtxTexture2.get_premultiplied_alpha(&self) @cname("ktxTexture2_GetPrem
ultipliedAlpha");
 455: fn bool KtxTexture2.needs_transcoding(&self) @cname("ktxTexture2_NeedsTranscod
ing");
                          ^^^^^^^^^^^^^^^^^
(C:/Users/User/vendor/libraries/ktx.c3l/ktx.c3i:455:21) Error: This method is alread
y defined for 'KtxTexture2'.

298: macro KtxErrorCode KtxTexture2.load_image_data(&self,
299:    char* pBuffer,
300:    usz bufSize) => self.vtbl.loadImageData(self, pBuffer, bufSize);
301: macro bool KtxTexture2.needs_transcoding(&self) => self.vtbl.needsTranscoding(s
elf);
                            ^^^^^^^^^^^^^^^^^
(C:/Users/User/vendor/libraries/ktx.c3l/ktx.c3i:301:24) Note: The previous definitio
n was here.

Is it ok for the ktx bindings to have the same name for macro and function?

@lerno
Copy link
Contributor

lerno commented Mar 16, 2026

That looks like a bug in the bindings?

@Darvisim
Copy link
Author

Darvisim commented Mar 16, 2026

That looks like a bug in the bindings?

Ah, so do i revert the changes made to ktx bindings then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants