Skip to content

Rollback job limits #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zelihacagip merged 2 commits into from
Apr 22, 2026
Merged

Rollback job limits #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea5121
* feat: add Prometheus metrics for Kotary configuration limits
zelihacagip Nov 18, 2024
41eff44
Merge branch 'master' into rollback/df168f9
zelihacagip Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/utils/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,10 @@ func parseConfigMap(configMap *v1.ConfigMap) (parsed *Config, err error) {

func setKotaryMetrics(kotaryConfig *Config) {

MaxJobsLimitNSGauge.Set(float64(kotaryConfig.MaxJobsLimitNS))
MaxJobsLimitClusterGauge.Set(float64(kotaryConfig.MaxJobsLimitCluster))
RatioMaxAllocationCPUGauge.Set(float64(kotaryConfig.RatioMaxAllocationCPU))
RatioMaxAllocationMemoryGauge.Set(float64(kotaryConfig.RatioMaxAllocationMemory))
RatioOverCommitCPUGauge.Set(float64(kotaryConfig.RatioOverCommitCPU))
RatioOverCommitMemoryGauge.Set(float64(kotaryConfig.RatioOverCommitMemory))

klog.Infof("Kotary metrics updated from configuration")
}

28 changes: 9 additions & 19 deletions internal/utils/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,22 @@ var DefaultClaimCounter = promauto.NewCounterVec(prometheus.CounterOpts{
Help: "Number of default claims created",
}, []string{"status"})

var MaxJobsLimitNSGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_max_jobs_batch_limit_ns",
Help: "Maximum number of jobs allowed per namespace",
})

var MaxJobsLimitClusterGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_max_jobs_batch_limit_cluster",
Help: "Maximum total number of jobs allowed across the cluster",
})

var RatioMaxAllocationCPUGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_ratio_max_allocation_cpu",
Help: "Maximum CPU allocation ratio allowed per namespace compared to total cluster CPU",
Name: "kotary_ratio_max_allocation_cpu",
Help: "Maximum CPU allocation ratio allowed per namespace compared to total cluster CPU",
})

var RatioMaxAllocationMemoryGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_ratio_max_allocation_memory",
Help: "Maximum memory allocation ratio allowed per namespace compared to total cluster memory",
Name: "kotary_ratio_max_allocation_memory",
Help: "Maximum memory allocation ratio allowed per namespace compared to total cluster memory",
})

var RatioOverCommitCPUGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_ratio_over_commit_cpu",
Help: "CPU over-commit ratio applied to node available resources (percentage)",
Name: "kotary_ratio_over_commit_cpu",
Help: "CPU over-commit ratio applied to node available resources (percentage)",
})

var RatioOverCommitMemoryGauge = promauto.NewGauge(prometheus.GaugeOpts{
Name: "kotary_ratio_over_commit_memory",
Help: "Memory over-commit ratio applied to node available resources (percentage)",
})
Name: "kotary_ratio_over_commit_memory",
Help: "Memory over-commit ratio applied to node available resources (percentage)",
})
Loading