Repository navigation
chore(scripts): harden lastSeen backfill + add coverage diagnostic - #352
Merged
Merged
Conversation
The first PROD lastSeen backfill silently under-stamped (875 of 1757): write failures (DynamoDB throttling) hit a console.error branch that incremented neither the stamped nor skipped counter, so the run reported success while ~882 people were left without lastSeen. - backfill-person-last-seen.js: retry transient/throttling errors with exponential backoff, count failures explicitly (non-zero exit + re-run hint), and use a steadier throttle. Still idempotent (forward-only condition). - check-last-seen-coverage.js: read-only diagnostic that compares people seen in relationships vs. people with lastSeen, splitting the gap into orphan refs (deleted person) vs. real misses. Used to verify full coverage. Verified after re-run: all 1757 existing seen people have lastSeen (8 remaining are orphan references to deleted people).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev-script-only change (no app/backend runtime impact).
Why
The first PROD lastSeen backfill silently under-stamped (875 of 1757 people).
Write failures (DynamoDB throttling) hit a console.error branch that incremented
neither counter, so the run reported success while ~882 people were left without
lastSeen.
Changes
exponential backoff, count failures explicitly (non-zero exit + re-run hint),
steadier throttle. Still idempotent (forward-only condition).
relationships vs. people with lastSeen, splitting the gap into orphan refs
(deleted person) vs. real misses.
Verified
After the hardened re-run: all 1757 existing seen people have lastSeen; 0
existing people missing it (8 remaining are orphan refs to deleted people).